Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Validate coin configs #40

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

naezith
Copy link
Collaborator

@naezith naezith commented Jun 23, 2023

GitHub Action does these checks:

  • The coins.json and coins_config.json in the Flutter project match the commit with the associated coins_repo_commit hash specified in coins_ci.json.
  • For supported coin types, check that all the wallet-only ("wallet_only": true) coins from assets/coins_config.json are listed in the walletOnlyCoins array in lib/app_config/app_config.dart
  • Ping all the URLs (regex) in lib/app_config/app_config.dart and ensure that none return a bad HTTP status.

Example:
image

Notes:

  • The response is falsely 404 for the GitHub.com and Discord redirecting links, so they are put in code as exceptions.

@naezith naezith marked this pull request as draft June 23, 2023 15:18
@naezith naezith marked this pull request as ready for review June 26, 2023 13:02
ca333
ca333 previously approved these changes Jul 16, 2023
@ca333
Copy link
Contributor

ca333 commented Aug 7, 2023

plz update target to dev branch @naezith

@naezith naezith changed the base branch from add_arrr to dev August 7, 2023 08:55
@naezith naezith dismissed ca333’s stale review August 7, 2023 08:55

The base branch was changed.

@naezith
Copy link
Collaborator Author

naezith commented Aug 7, 2023

@ca333 Done. The branch is from add_arrr though so now it's 93 commits instead of 5.

@naezith naezith changed the base branch from dev to add_arrr August 8, 2023 09:10
@ca333 ca333 merged commit 441a971 into KomodoPlatform:add_arrr Aug 8, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants