Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix advanced swap order book showing incorrect values #119

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fix advanced swap order book showing incorrect values #119

merged 2 commits into from
Mar 6, 2024

Conversation

takenagain
Copy link
Collaborator

Fixes #118 by

  • converting the USD-based max volume to the coin amount, and
  • limiting the received amount to the maximum volume of the Rel coin.

The maximum volume of the base coin is used with the orderbook v2 endpoint, leading to incorrect values where the received coin is displayed as more than the maximum volume or less than the requested volume.

Before:
image

After:
image

Desktop:
image

@takenagain takenagain added the QA Ready for QA testing label Feb 27, 2024
@takenagain takenagain self-assigned this Feb 27, 2024
@takenagain takenagain marked this pull request as ready for review February 27, 2024 17:22
kivqa
kivqa approved these changes Feb 27, 2024
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Orderbook for Swap Advanced is correct and same as Orderbook on Market screen and orderbook in Desktop app.
Checked on Android

@takenagain takenagain requested a review from CharlVS March 4, 2024 14:23
@CharlVS CharlVS merged commit 571a223 into dev Mar 6, 2024
1 check passed
@CharlVS CharlVS linked an issue May 9, 2024 that may be closed by this pull request
Incorrect Orderbook on Swap Advanced #118
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlVS CharlVS CharlVS approved these changes

@kivqa kivqa kivqa approved these changes

@smk762 smk762 Awaiting requested review from smk762

Assignees

@takenagain takenagain

Labels
QA Ready for QA testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Orderbook on Swap Advanced
3 participants
@takenagain @CharlVS @kivqa