Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance my_recent_swaps RPC with Event-Specific Filters #2181

Open
shamardy opened this issue Jul 29, 2024 · 0 comments
Open

Enhance my_recent_swaps RPC with Event-Specific Filters #2181

shamardy opened this issue Jul 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@shamardy
Copy link
Collaborator

Overview

my_recent_swaps RPC currently provides a comprehensive list of swap events for both v1 and v2 protocols. However, there is a need to streamline the process for users who rely on specific event types, such as MakerPaymentRefundFailed and TakerPaymentSpendFailed, for their workflows.

Problem

Users, particularly those operating seed and maker nodes, have expressed concerns regarding the transition to database-driven swap data management. The absence of JSON files for v2 swaps poses challenges for existing processes that depend on these files for statistics, recovery, and refund operations.

Proposed Solution

Introduce filters within the my_recent_swaps RPC call to allow users to retrieve swaps that have specific events. This enhancement will significantly reduce the overhead of manually searching through swap data and improve the efficiency of recovery and refund workflows.

Benefits

  • Simplifies the process of identifying and recovering failed swaps.
  • Maintains compatibility with existing systems that depend on JSON file outputs.

Additional Considerations

  • Explore the feasibility of an RPC call to edit swap data/events in the database for cases where manual intervention is required.

This issue aims to address the concerns raised in the discussion with @cipig regarding the impact of database changes on maker nodes operations and the potential for a streamlined swap event filtering. Related comment: #2043 (comment)

@shamardy shamardy added the enhancement New feature or request label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant