Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement additional validation for tendermint pubkey only activation #2146

Open
borngraced opened this issue Jun 18, 2024 · 0 comments
Open

Comments

@borngraced
Copy link
Member

borngraced commented Jun 18, 2024

KDF panics during a swap when tendermint is activated using pubkey only activation with a 32-byte Ed25519 public key. This issue arises because the maker_coin_htlc_pubkey and taker_coin_htlc_pubkey requires a SECP256k1, which is a 33-byte public key.

let maker_coin_htlc_pubkey = self.maker_coin.derive_htlc_pubkey(&unique_data);
let taker_coin_htlc_pubkey = self.taker_coin.derive_htlc_pubkey(&unique_data);

let maker_coin_htlc_pubkey = self.maker_coin.derive_htlc_pubkey(&unique_data);
let taker_coin_htlc_pubkey = self.taker_coin.derive_htlc_pubkey(&unique_data);

sample activation pubkey

"with_pubkey": {
  "type": "ed25519",
  "value": [69, 185, 115, 48, 238, 34, 179, 146, 245, 133, 156, 250, 194, 142, 36, 61, 186, 109, 204, 236, 174, 123, 162, 211, 147, 143, 165, 62, 16, 245, 21, 25]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant