Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise filesize of assets used in guis #872

Open
smk762 opened this issue Nov 27, 2023 · 1 comment · May be fixed by #875
Open

Optimise filesize of assets used in guis #872

smk762 opened this issue Nov 27, 2023 · 1 comment · May be fixed by #875
Assignees
@gcharang @cipig @smk762 @CharlVS

Comments

@smk762
Copy link
Collaborator

smk762 commented Nov 27, 2023

  • Images already optimised in CI/CD flow, need to confirm this is what all repos use.
  • Vector file formats like svg would be good where possible
  • coins_config.json could be trimmed, some fields are not required for guis. Some field names could be shortened.
  • We should also serve a minified version for the guis to reduce the file size.
@cipig
Copy link
Member

cipig commented Nov 27, 2023

  • Vector file formats like svg would be good where possible

Many icons are from here: https://github.com/spothq/cryptocurrency-icons (the 128 pixel PNGs)
They are also available as SVG: https://github.com/spothq/cryptocurrency-icons/tree/master/svg/icon
But we will need to select them by hand, because some coins have replaced their icons from there with their own, more recent versions.

@smk762 smk762 linked a pull request Nov 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcharang gcharang

@cipig cipig

@smk762 smk762

@CharlVS CharlVS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimise GUI asset files KomodoPlatform/coins
4 participants
@gcharang @cipig @smk762 @CharlVS