Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update segwit derivation paths #851

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update segwit derivation paths #851

wants to merge 2 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Oct 30, 2023

@smk762 smk762 requested review from dimxy and cipig October 30, 2023 06:22
@dimxy
Copy link

dimxy commented Oct 30, 2023

I can see several segwit coins with no derivation path set at all.
We did not assign it because there is no standard value for those coins?

@smk762
Copy link
Collaborator Author

smk762 commented Nov 3, 2023

I can see several segwit coins with no derivation path set at all. We did not assign it because there is no standard value for those coins?

Info was sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md a while ago.
trezor_coin value comes from https://trezor.io/coins where available.

I've added a check to the config gen script to highlight the coins with missing / incorrect derivation path, results are:

Segwit coins with no derivation path: ['BSTY-segwit', 'tQTUM-segwit', 'tBTC-segwit', 'WHIVE-segwit']
Segwit coins with bad derivation path: []
Segwit coins with no trezor coin: [
    'BSTY-segwit',
    'CDN-segwit',
    'CY-segwit',
    'LBC-segwit',
    'LCC-segwit',
    'WCN-segwit',
    'tQTUM-segwit',
    'tBTC-segwit',
    'XEP-segwit',
    'XMY-segwit',
    'WHIVE-segwit'
]

I rechecked the sources and found no new data to update the coins file at this time.

@dimxy
Copy link

dimxy commented Nov 4, 2023

Info was sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md a while ago.

I see, I'll discuss with @shamardy what we should do with coins for which there is no assigned coin type

@smk762 smk762 added the on hold label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segwit derivation paths
3 participants