Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingests that use symmetric edge_labels (like interacts_with) should assert edge in both directions #328

Open
justaddcoffee opened this issue Sep 3, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@justaddcoffee
Copy link
Collaborator

Describe the bug

Some ingests like IntAct and STRING use symmetric edge labels like interacts_with. These should assert in both directions:
if ingest asserts:
A interacts_with B
it should also assert:
B interacts with A

To Reproduce

Example, STRING has this edge:
ENSEMBL:ENSP00000256935 biolink:interacts_with ENSEMBL:ENSP00000439601 RO:0002434

So it should also have:
ENSEMBL:ENSP00000439601 biolink:interacts_with ENSEMBL:ENSP00000256935 RO:0002434

Expected behavior

See above

Version

Example above is for the Aug 17 build

@justaddcoffee justaddcoffee added bug Something isn't working enhancement New feature or request labels Sep 3, 2020
@justaddcoffee
Copy link
Collaborator Author

This applies to at least 7 ingests currently:

grep -l interacts_with `find data/transformed/ -name "*edge*tsv" `
data/transformed//ttd/edges.tsv
data/transformed//drug_central/edges.tsv
data/transformed//pharmgkb/edges.tsv
data/transformed//zhou_host_proteins/edges.tsv
data/transformed//ChEMBL/edges.tsv
data/transformed//STRING/edges.tsv
data/transformed//intact/edges.tsv

Possibly would be worth considering adding this enhancement to KGX instead of adding this to each of the above ingests (I could help with this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant