🐛 Mend the bug: can't write in and read the file

Author: KleMoretti

Functions.cpp

@@ -17,7 +17,7 @@ void Exit() {
 //read用于将文件中的信息重新储存到容器中
 void ReadInfo(std::vector<std::unique_ptr<Person>> &loadedObjects) {
     // 从文件加载对象
-    std::ifstream ifs("WokerManager.txt", std::ios::binary);
+    std::ifstream ifs("WorkerManager.txt", std::ios::binary);
     if (!ifs.is_open()) {
         throw std::runtime_error("Could not open file for reading.");
     }
@@ -26,24 +26,44 @@ void ReadInfo(std::vector<std::unique_ptr<Person>> &loadedObjects) {
         try {
             auto obj = Person::deserialize(ifs);
             loadedObjects.push_back(std::move(obj));
-        } catch (const std::exception&) {
-            break; // 如果文件结束，捕获异常并退出循环
+        } catch (const std::exception& e) {
+            // 捕获异常
+            if (ifs.eof()) { // 检查是否到达文件末尾
+                break;
+            }
+            std::cerr << "Error during deserialization: " << e.what() << std::endl;
+            throw; // 重新抛出异常以通知调用者
         }
     }
     ifs.close();
 }
 
 void SaveInfo(const std::vector<std::unique_ptr<Person>> &objects) {
     // 保存到文件
-    std::ofstream ofs("WorkerManager.txt", std::ios::binary);
+    std::ofstream ofs("WorkerManager.txt", std::ios::binary | std::ios::out);
     if (!ofs.is_open()) {
         throw std::runtime_error("Could not open file for writing.");
     }
 
-    for (const auto& obj : objects) {
-        obj->write(ofs);
+    try {
+        for (const auto& obj : objects) {
+            if (!obj) {
+                std::cerr << "Encountered null pointer in object list." << std::endl;
+                continue;  // 或者抛出异常，取决于具体需求
+            }
+            obj->write(ofs);
+            // 检查输出是否成功
+            if (!ofs) {
+                std::cerr << "Error writing to file." << std::endl;
+                break;  // 停止写入，避免更多的错误
+            }
+        }
+    } catch (const std::exception&e) {
+        std::cerr << "Error"<<e.what()<<std::endl;
+        // 在捕获所有异常的情况下关闭文件
+        // ofs.close();  // 这里实际上不需要调用 close，因为 ofs 已经在作用域结束时自动关闭
+        throw;  // 重新抛出异常
     }
-    ofs.close();
 }
 
 
@@ -183,7 +203,7 @@ void ModifyInformation(std::vector<std::unique_ptr<Person>> &Objects) {
                 bool found=false;
                 for(const auto& obj : Objects) {
                     if(obj->Number()==num) {
-                        std::cout << "Please input the new name: ";
+                        std::cout << "Please input the new number: ";
                         int newNum;
                         std::cin >> newNum;
                         obj->ChangeNumber(newNum);
@@ -313,6 +333,7 @@ void SortInformation(std::vector<std::unique_ptr<Person>> &Objects) {
 
 void ClearAlltxt(std::vector<std::unique_ptr<Person>> &Objects) {
     Objects.clear();
+    SaveInfo(Objects);
     std::cout << "All information has been cleared." << std::endl;
 }
 

WorkerClass.cpp

@@ -8,8 +8,6 @@
 std::unique_ptr<Person> Person::deserialize(std::istream& is) {
         int kind;
         is >> kind;
-
-
         switch (kind) {
                 case Person::Worker:
                         return Worker::fromStream(is);

WorkerClass.h

@@ -66,6 +66,10 @@ class Worker : public Person {
     void ShowDuty() override ;
     void write(std::ostream& os) const override {
         os << static_cast<int>(Person::Worker) << ' ' << Number() << ' ' << Name() << '\n';
+        // 检查输出是否成功
+        if (!os) {
+            std::cerr << "Error writing to stream." << std::endl;
+        }
     }
 
     void read(std::istream& is) override ;
@@ -103,6 +107,10 @@ class Manager : public Person {
 
     void write(std::ostream& os) const override {
         os << static_cast<int>(Person::Manager) << ' ' << Number() << ' ' << Name() << '\n';
+        // 检查输出是否成功
+        if (!os) {
+            std::cerr << "Error writing to stream." << std::endl;
+        }
     }
 
     void read(std::istream& is) override ;
@@ -140,6 +148,10 @@ class Boss : public Person {
 
     void write(std::ostream& os) const override {
         os << static_cast<int>(Person::Boss) << ' ' << Number() << ' ' << Name() << '\n';
+        // 检查输出是否成功
+        if (!os) {
+            std::cerr << "Error writing to stream." << std::endl;
+        }
     }
 
     void read(std::istream& is) override ;

cmake-build-debug/.ninja_deps

@@ -71,3 +71,13 @@
 4	396	7450902753258483	CMakeFiles/WorkerManagerSystem.dir/WorkerClass.cpp.obj	80e12e65f852bef9
 16	476	7450902753383197	CMakeFiles/WorkerManagerSystem.dir/Functions.cpp.obj	3d61f7412b6d32b0
 476	606	7450902757973532	WorkerManagerSystem.exe	4ce8cc964464a38d
+21	282	7451681599762598	CMakeFiles/WorkerManagerSystem.dir/context.cpp.obj	ab7e873d7c93df0c
+7	341	7451681599631404	CMakeFiles/WorkerManagerSystem.dir/main.cpp.obj	3ca4f3006d423f01
+33	524	7451681599861479	CMakeFiles/WorkerManagerSystem.dir/Functions.cpp.obj	3d61f7412b6d32b0
+524	657	7451681604763493	WorkerManagerSystem.exe	4ce8cc964464a38d
+6	368	7452217620757089	CMakeFiles/WorkerManagerSystem.dir/main.cpp.obj	3ca4f3006d423f01
+18	394	7452217620880097	CMakeFiles/WorkerManagerSystem.dir/WorkerClass.cpp.obj	80e12e65f852bef9
+30	531	7452217621000298	CMakeFiles/WorkerManagerSystem.dir/Functions.cpp.obj	3d61f7412b6d32b0
+531	668	7452217626011925	WorkerManagerSystem.exe	4ce8cc964464a38d
+3	1590	7452222951452804	CMakeFiles/WorkerManagerSystem.dir/Functions.cpp.obj	3d61f7412b6d32b0
+1590	7183	7452222967315546	WorkerManagerSystem.exe	4ce8cc964464a38d

cmake-build-debug/.ninja_log

@@ -1,3 +1,3 @@
-Start testing: Aug 12 19:46 �й���׼ʱ��
+Start testing: Aug 13 11:18 �й���׼ʱ��
 ----------------------------------------------------------
-End testing: Aug 12 19:46 �й���׼ʱ��
+End testing: Aug 13 11:18 �й���׼ʱ��

cmake-build-debug/CMakeFiles/WorkerManagerSystem.dir/Functions.cpp.obj

@@ -1 +1,5 @@
-3 1001 Aiden
+3 3001 Already
+3 3002 Jerry
+3 3003 Aodaly
+2 2001 Cihelo
+2 2006 ASAP