Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Some rendering tests ar not doing their job #3136

Open
bruyeret opened this issue Oct 1, 2024 · 0 comments
Open

[Bug] Some rendering tests ar not doing their job #3136

bruyeret opened this issue Oct 1, 2024 · 0 comments
Labels
type: bug 🐞 Errors in functionality

Comments

@bruyeret
Copy link
Contributor

bruyeret commented Oct 1, 2024

Bug description

These tests should fail or the reference should be updated and the threshold decreased
image
image
image

This succeed as expected but the image have to be updated (I did some changes in this PR #3095 so I know the result is ok) and the threshold decreased
image
See this test that I added and that seems to work fine:
image

Steps to reproduce

Run the tests and give a look at the report.

Detailed Behavior

No response

Expected Behavior

Mentionned tests should be updated to fail and the corresponding code should be fixed.

Environment

  • vtk.js version: master
  • Browsers: any
  • OS: any
@bruyeret bruyeret added the type: bug 🐞 Errors in functionality label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐞 Errors in functionality
Projects
None yet
Development

No branches or pull requests

1 participant