Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] #3084

Open
sctstudent opened this issue Jun 13, 2024 · 3 comments
Open

[Bug] #3084

sctstudent opened this issue Jun 13, 2024 · 3 comments
Labels
good first issue 👋 module: typescript Issues related to typescript definitions module: widget Gaps and errors in interactive widgets type: feature request 💡 Desired capabilities / enhancements

Comments

@sctstudent
Copy link

Bug description

How do I introduce LineWidgets in typescript

Steps to reproduce

import vtkLineWidget from "@kitware/vtk.js/Widgets/Widgets3D/LineWidget";

Detailed Behavior

No response

Expected Behavior

import vtkLineWidget from "@kitware/vtk.js/Widgets/Widgets3D/LineWidget";

Environment

  • vtk.js version:
  • Browsers:
  • OS:
@sctstudent sctstudent added the type: bug 🐞 Errors in functionality label Jun 13, 2024
@finetjul
Copy link
Member

It is missing a typescript file.
Can you please create a PR that adds into the LineWidget folder an index.d.ts file ?

@finetjul finetjul added module: widget Gaps and errors in interactive widgets module: typescript Issues related to typescript definitions type: feature request 💡 Desired capabilities / enhancements good first issue 👋 and removed type: bug 🐞 Errors in functionality labels Jun 13, 2024
@vasut02
Copy link

vasut02 commented Jun 15, 2024

Can I fix this issue?

@bruyeret
Copy link
Contributor

Can I fix this issue?

Of course, anyone can do a PR 👍
You can read CONTRIBUTING.md first
It is very easy to contribute, as contributions are the strength of Open Source projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 👋 module: typescript Issues related to typescript definitions module: widget Gaps and errors in interactive widgets type: feature request 💡 Desired capabilities / enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@finetjul @vasut02 @bruyeret @sctstudent