Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createMultipleAnnotations has a bug if you include annotationIds in the input set of annotations #782

Open
arjunrajlab opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@arjunrajlab
Copy link
Collaborator

createMultipleAnnotations allows you to send a list of annotations for addition to the server. However, in that call, if the annotations contain an _id key/value, it will upload but get confused. I have found, for instance, that connections between the annotations will no longer work. I am guessing this is because it screws up the commit to the database because it has an existing _id but is also trying to assign a new one or something like that. It would be better, I think, to strip any _id keys that are sent to the server via this endpoint.

This came up in the AI worker where I want to get a list of annotations and then send those same annotations back to the server, resulting in strange behavior. When I removed the _id fields from the annotations I sent with createMultipleAnnotations, it worked fine. It's probably good practice to not send the _id fields to this endpoint, but still, I think the server should catch this error.

@arjunrajlab arjunrajlab added the bug Something isn't working label Sep 24, 2024
@arjunrajlab arjunrajlab added this to the Alpha-Version milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Selected for development
Development

No branches or pull requests

2 participants