Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDB insertions performance #870

Open
leplatrem opened this issue Oct 31, 2018 · 1 comment
Open

IDB insertions performance #870

leplatrem opened this issue Oct 31, 2018 · 1 comment
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@leplatrem
Copy link
Contributor

Iterating on list in order to perform massive IndexedDB insertions is not efficient.

We should chain insertions instead for the browser to schedule the insertions better.
leplatrem added a commit that referenced this issue Oct 31, 2018
@leplatrem
Ref #870: better bulk insert for IDB loadDump()
e64e6cc
@leplatrem leplatrem mentioned this issue Oct 31, 2018
Merged
@leplatrem
Copy link
Contributor Author

For the bulk insert in Collection.importChanges, maybe we should iterate in chunks instead. Modifying the storage adapter interface is less obvious. But maybe we could rely on loadDump() there too :) I'll investigate

leplatrem added a commit that referenced this issue Nov 2, 2018
@leplatrem
Ref #870: better bulk insert for IDB loadDump() (#871)
aacf46f 
* Ref #870: better bulk insert for IDB loadDump()

* Add comment
@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leplatrem @alexcottner