New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectPath allows characters that are disallowed in the spec #125

Open

Cobinja opened this issue Nov 24, 2024 · 1 comment

Labels

good first issue

Cobinja commented Nov 24, 2024

According to https://dbus.freedesktop.org/doc/dbus-specification.html#basic-types, object path elements must only contain the ASCII characters a-z, A-Z, 0-9 and _

https://github.com/KillingSpark/rustbus/blob/master/rustbus/src/params/validation.rs#L57 uses is_alphanumeric(), which also covers various other characters such as german umlauts ä, ö and ü.

Owner

KillingSpark commented Nov 25, 2024

Huh that's true. I guess it should be "is_ascii" instead.

KillingSpark added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment