Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return different error messages for missing json as opposed to poorly formatted json #60

Open
Kieranties opened this issue Mar 28, 2019 · 0 comments
Open

Return different error messages for missing json as opposed to poorly formatted json #60

Kieranties opened this issue Mar 28, 2019 · 0 comments
Assignees
@Kieranties
Labels
✨ feature New feature or request 🏆 good first issue Good for newcomers
Milestone
0.4.0

Comments

@Kieranties
Copy link
Owner

Currently the same error message is returned for the following scenarios:

  1. The .simpleversion.json file is not commmitted
  2. The .simpleversion.json file could not be parsed.

More information should be provided in the scenario that the file could not be parsed. E.g. at what commit(s), and the error returned.
@Kieranties Kieranties self-assigned this Mar 28, 2019
@Kieranties Kieranties added ✨ feature New feature or request 🏆 good first issue Good for newcomers labels Mar 28, 2019
@Kieranties Kieranties added this to the 0.2.0 milestone Jun 30, 2019
@Kieranties Kieranties mentioned this issue Jul 2, 2019
Merged
20 tasks
@Kieranties Kieranties modified the milestones: 0.2.0, 0.3.0 Feb 25, 2020
@Kieranties Kieranties modified the milestones: 0.3.0, 0.4.0 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kieranties Kieranties

Labels
✨ feature New feature or request 🏆 good first issue Good for newcomers
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@Kieranties