Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF loader for api samples is severely limited #848

Open
SaschaWillems opened this issue Nov 11, 2023 · 2 comments
Open

glTF loader for api samples is severely limited #848

SaschaWillems opened this issue Nov 11, 2023 · 2 comments
Labels
framework This is relevant to the framework

Comments

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Nov 11, 2023

While working on a new sample requiring me to render a complete glTF scene I noticed that the glTF loader for the api samples is severely limited. It can only load (and display) a single mesh with a single primitive from a glTF file. That's a real hindrance and something we should address near-term. It also does not apply any matrices, so scenes aren't scaled properly.

Sadly the glTF loader initially taken from my code has been partially wired to the framework, making it non-trivial to fix this without needing to change a lot of things.

@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Nov 11, 2023
@SaschaWillems SaschaWillems changed the title glTF loader for api sample is severely limited glTF loader for api samples is severely limited Nov 13, 2023
@SaschaWillems
Copy link
Collaborator Author

As a workaround one can go iterate over the meshes in vkb::sg::Scene. But that then requires lots of manual things do be done explicitly in a sample (materials, matrices, etc). and is something we could simplify to open this option to all api samples.

@SaschaWillems
Copy link
Collaborator Author

But even using the workaround mentioned above: the current glTF loader in the framework crashes with some very basic glTF files (only few static meshes, no images, etc.) that work fine in my samples. So this is something we should tackel.

SaschaWillems added a commit to SaschaWillems/Vulkan-Samples that referenced this issue Jan 27, 2024
Initialize base color
Removed assert that would trigger on some basic glTFs
Refs KhronosGroup#848
marty-johnson59 pushed a commit that referenced this issue Sep 6, 2024
* Updated Vulkan headers tp 1.3.276

* Only destroy render pass if != null

Required for samples that don't use render passes

* Added support for loading colors from glTF files

Initialize base color
Removed assert that would trigger on some basic glTFs
Refs #848

* Added new sample for dynamic rendering local read

Copy from internal git repository

* Added dynamic rendering local read sample to readme and docs navigation

* Update copyright
Fix clang format

* Adjusted memory barrier

* Clean up api sample base class interfaces

* Revert "Clean up api sample base class interfaces"

This reverts commit 7504395.

* Adjust to recent framework changes

* Clang format

* Disable GUI for dynamic rendering
Would require fixes to the framework

* Tring to fix things

* Correct merge error

* Added missing break

* Fix documentation

* Minor cleanup

* Desperately trying to fix clang format

* Trying to fix CI

* Trying to fix CI

* Clang format
IMO not correct, but the only way to get that build step running

* Added read-only flag to lights buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This is relevant to the framework
Projects
None yet
Development

No branches or pull requests

1 participant