Add missing VK_KHR_portability_subset extension to [hpp_]hello_triangle[*] samples #1284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If portability is enabled (i.e.
VKB_ENABLE_PORTABILITY
) and the device supports the extension at runtime, this PR adds theVK_KHR_portability_subset
device extension in the standalone samples:hello_triangle
,hpp_hello_triangle
, andhello_triangle_1_3
. This is required by the spec and prevents validation errors when the validation layer is enabled.There is no change to the general framework where
VK_KHR_portability_subset
is already enabled as required for other non-standalone samples.Fixes #1283
Tested on macOS Ventura and iOS (iPhone 15 physical device and simulator).
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: