Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vulkan SDK to version 1.4.304 #1281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Vulkan SDK to version 1.4.304 #1281

wants to merge 1 commit into from

Conversation

asuessenbach
Copy link
Contributor

@asuessenbach asuessenbach commented Feb 25, 2025 •
edited
Loading

Description

Updating to Vulkan SDK 1.4.304 required some namespace adjustments in our code.

Fixes #1269

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@asuessenbach asuessenbach requested a review from a team February 25, 2025 11:34
@SRSaunders
Copy link
Contributor

SRSaunders commented Feb 25, 2025 •
edited
Loading

@asuessenbach this looks good, but may also affect the debug callback in shader_debugprintf.

Can I please ask you to hold off on this PR until #1187 is merged? Hopefully will be very soon as it's been sitting a long time. Once that is done, you could add any necessary shader_debugprintf callback changes to this PR.

@SaschaWillems SaschaWillems self-requested a review February 25, 2025 15:40
SaschaWillems
SaschaWillems approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SRSaunders SRSaunders mentioned this pull request Feb 25, 2025
Merged
20 tasks
@SRSaunders
Copy link
Contributor

SRSaunders commented Feb 25, 2025 •
edited
Loading

@asuessenbach #1187 is now merged.

Please feel free to convert the debug callback in shader_debugprintf to the vk:: namespace if required. Perhaps it's not in this case, but I'll leave that up to you to determine. Thanks.

@asuessenbach
Copy link
Contributor Author

@SRSaunders as the shader_debugprintf sample uses the C-bindings of vulkan, there's no need to change anything here. The adjustments are needed for the C++-bindings only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaWillems SaschaWillems SaschaWillems approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heads-up re vk::DynamicLoader namespace change in vulkan.hpp >= v301
3 participants
@asuessenbach @SRSaunders @SaschaWillems