Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue about vkPipelineCreationFeedbackTests.cpp #494

Open
geniusAhua opened this issue Oct 29, 2024 · 0 comments
Open

Issue about vkPipelineCreationFeedbackTests.cpp #494

geniusAhua opened this issue Oct 29, 2024 · 0 comments

Comments

@geniusAhua
Copy link

geniusAhua commented Oct 29, 2024

In the file

// We only set the warning when the pipeline nor the pipeline stages hit the cache. If any of them did, them disable the warning.
, at line 988 and 1401. These two comments mention that any of them (pipeline and pipeline stages) hit the cache, the warning will be disable.

However, actually, the execution logic does not match the description in the comments.
When pipeline hits the cache but pipeline stages don't, the warning still be active.

Is there a problem with this part, or is my understanding incorrect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant