From d26831a0415669dc985a815e3fc89b6f1d34cabb Mon Sep 17 00:00:00 2001 From: John Pennycook Date: Thu, 12 Dec 2024 15:26:40 +0000 Subject: [PATCH] Remove *_reduce functions for kernel objects There are currently no backends that define interop for reductions, so we can remove these functions for now. If we decide later that these functions are necessary, we can release a revision of the KHR. --- .../sycl_khr_free_function_commands.adoc | 92 ------------------- 1 file changed, 92 deletions(-) diff --git a/adoc/extensions/sycl_khr_free_function_commands.adoc b/adoc/extensions/sycl_khr_free_function_commands.adoc index b410df5f..a373e565 100644 --- a/adoc/extensions/sycl_khr_free_function_commands.adoc +++ b/adoc/extensions/sycl_khr_free_function_commands.adoc @@ -257,49 +257,6 @@ _Effects (4-6)_: Equivalent to [code]#+q.submit([&](handler& h) { launch_reduce(h, r, k, reductions...); })+#. -''' - -.[apititle]#launch_reduce# (kernel object) -[source,role=synopsis,id=api:launch_reduce-kernel] ----- -namespace sycl::khr { - -template -void launch_reduce(sycl::handler& h, sycl::range<1> r, - const sycl::kernel& k, Args&&... args); (1) - -template -void launch_reduce(sycl::handler& h, sycl::range<2> r, - const sycl::kernel& k, Args&&... args); (2) - -template -void launch_reduce(sycl::handler& h, sycl::range<3> r, - const sycl::kernel& k, Args&&... args); (3) - -template -void launch_reduce(sycl::queue q, sycl::range<1> r, - const sycl::kernel& k, Args&&... args); (4) - -template -void launch_reduce(sycl::queue q, sycl::range<2> r, - const sycl::kernel& k, Args&&... args); (5) - -template -void launch_reduce(sycl::queue q, sycl::range<3> r, - const sycl::kernel& k, Args&&... args); (6) - -} ----- -_Effects (1-3)_: Equivalent to: -[source,c++] ----- -h.set_args(args...); -h.parallel_for(r, k); ----- - -_Effects (4-6)_: Equivalent to [code]#+q.submit([&](handler& h) { -launch_reduce(h, r, k, args...); })+#. - ''' .[apititle]#launch_grouped# (kernel function) @@ -431,55 +388,6 @@ launch_grouped_reduce(h, r, size, k, reductions...); })+#. ''' -.[apititle]#launch_grouped_reduce# (kernel object) -[source,role=synopsis,id=api:launch_grouped_reduce-kernel] ----- -namespace sycl::khr { - -template -void launch_grouped_reduce(sycl::handler& h, sycl::range<1> r, - sycl::range<1> size, const sycl::kernel& k, - Args&&... args); (1) - -template -void launch_grouped_reduce(sycl::handler& h, sycl::range<2> r, - sycl::range<2> size, const sycl::kernel& k, - Args&&... args); (2) - -template -void launch_grouped_reduce(sycl::handler& h, sycl::range<3> r, - sycl::range<3> size, const sycl::kernel& k, - Args&&... args); (3) - -template -void launch_grouped_reduce(sycl::queue q, sycl::range<1> r, - sycl::range<1> size, const sycl::kernel& k, - Args&&... args); (4) - -template -void launch_grouped_reduce(sycl::queue q, sycl::range<2> r, - sycl::range<2> size, const sycl::kernel& k, - Args&&... args); (5) - -template -void launch_grouped_reduce(sycl::queue q, sycl::range<3> r, - sycl::range<3> size, const sycl::kernel& k, - Args&&... args); (6) - -} ----- -_Effects (1-3)_: Equivalent to: -[source,c++] ----- -h.set_args(args...); -h.parallel_for(nd_range(r, size), k); ----- - -_Effects (4-6)_: Equivalent to [code]#+q.submit([&](handler& h) { -launch_grouped_reduce(h, r, size, k, args...); })+#. - -''' - .[apititle]#launch_task# (kernel function) [source,role=synopsis,id=api:launch_task] ----