Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react.md to use imported Component #59

Open
joshwcomeau opened this issue Apr 10, 2017 · 0 comments
Open

Update react.md to use imported Component #59

joshwcomeau opened this issue Apr 10, 2017 · 0 comments

Comments

@joshwcomeau
Copy link
Contributor

joshwcomeau commented Apr 10, 2017

I believe it's safe to say, after the internal vote, that people prefer:

import React, {Component} from "react";

class Thing extends Component { ... }

over

import React from "react";

class Thing extends React.Component { ... }

The examples in react.md all use the React.Component style, so we should update them to just extend Component. We can also add a blurb about the import convention?

cc @kevinbarabash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant