From 79b1ff3ed5251a061f5b463d616e7100798dc95b Mon Sep 17 00:00:00 2001 From: Ivy Olamit Date: Tue, 11 Mar 2025 11:51:38 -0700 Subject: [PATCH 1/6] Reinstate the focus outline of the x button in math-input component, and adjusted styling --- .../src/components/keypad/keypad-mathquill.stories.tsx | 2 +- packages/math-input/src/components/keypad/shared-keys.tsx | 2 +- packages/perseus/src/components/math-input.tsx | 8 +++----- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/math-input/src/components/keypad/keypad-mathquill.stories.tsx b/packages/math-input/src/components/keypad/keypad-mathquill.stories.tsx index ae4331c041..2ca7af741a 100644 --- a/packages/math-input/src/components/keypad/keypad-mathquill.stories.tsx +++ b/packages/math-input/src/components/keypad/keypad-mathquill.stories.tsx @@ -77,7 +77,7 @@ export function V2KeypadWithMathquill() { content={ diff --git a/packages/math-input/src/components/keypad/shared-keys.tsx b/packages/math-input/src/components/keypad/shared-keys.tsx index 18308ef4ae..e256987d09 100644 --- a/packages/math-input/src/components/keypad/shared-keys.tsx +++ b/packages/math-input/src/components/keypad/shared-keys.tsx @@ -103,7 +103,7 @@ export default function SharedKeys(props: Props) { keyConfig={Keys.BACKSPACE} onClickKey={onClickKey} coord={[5, 3]} - action + secondary /> ); diff --git a/packages/perseus/src/components/math-input.tsx b/packages/perseus/src/components/math-input.tsx index 690e1deec9..462084a710 100644 --- a/packages/perseus/src/components/math-input.tsx +++ b/packages/perseus/src/components/math-input.tsx @@ -341,9 +341,6 @@ class InnerMathInput extends React.Component { /> this.closeKeypad()} - dismissEnabled aria-label={this.context.strings.mathInputTitle} aria-describedby={`popover-content-${popoverContentUniqueId}`} content={() => ( @@ -355,7 +352,6 @@ class InnerMathInput extends React.Component { {this.context.strings.mathInputDescription} { mapButtonSets( this.props?.buttonSets, ))} + showDismiss /> )} + dismissEnabled + opened={this.state.keypadOpen} > {this.props.buttonsVisible === "never" ? ( Date: Tue, 11 Mar 2025 12:03:54 -0700 Subject: [PATCH 2/6] update snapshots --- .../__tests__/__snapshots__/keypad.test.tsx.snap | 4 ++-- .../__tests__/__snapshots__/renderer.test.tsx.snap | 6 +++--- .../dropdown/__snapshots__/dropdown.test.ts.snap | 4 ++-- .../__snapshots__/graded-group-set-jipt.test.ts.snap | 6 +++--- .../__snapshots__/graded-group-set.test.ts.snap | 2 +- .../__snapshots__/graded-group.test.ts.snap | 2 +- .../__snapshots__/interactive-graph.test.tsx.snap | 12 ++++++------ .../widgets/video/__snapshots__/video.test.ts.snap | 4 ++-- 8 files changed, 20 insertions(+), 20 deletions(-) diff --git a/packages/math-input/src/components/keypad/__tests__/__snapshots__/keypad.test.tsx.snap b/packages/math-input/src/components/keypad/__tests__/__snapshots__/keypad.test.tsx.snap index e149a9ebdc..142e52d663 100644 --- a/packages/math-input/src/components/keypad/__tests__/__snapshots__/keypad.test.tsx.snap +++ b/packages/math-input/src/components/keypad/__tests__/__snapshots__/keypad.test.tsx.snap @@ -835,7 +835,7 @@ exports[`keypad should snapshot expanded: first render 1`] = ` class="default_xu2jcg-o_O-outerBoxBase_3w5jmh" >