From 2441a3b9ba25bfe7e7725e9dc08fdf1a839db195 Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Wed, 14 Feb 2024 19:22:31 -0800 Subject: [PATCH 1/3] Pin workflows to see if that fixes lint --- .github/workflows/go.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 8faa3cc9..1aa23881 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -12,11 +12,11 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - go: [ '1.18', '1.19', '1.20' ] + go: [ '1.18', '1.19', '1.20', '1.21', '1.22' ] steps: - name: Set up Go - uses: actions/setup-go@v1 + uses: actions/setup-go@v4 with: go-version: ${{ matrix.go }} id: go @@ -36,10 +36,16 @@ jobs: runs-on: ubuntu-latest steps: + - name: Set up Go + uses: actions/setup-go@v4 + with: + go-version: '1.20' + id: go + - name: Git checkout uses: actions/checkout@v2 - name: Run lint - uses: golangci/golangci-lint-action@v2 + uses: golangci/golangci-lint-action@v3 with: version: v1.52.2 # should match internal/lint/go.mod From 7b4c785fff4b7929992e36b72653a780b5ca706c Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Wed, 14 Feb 2024 19:24:07 -0800 Subject: [PATCH 2/3] no 1.22, lint 1.21 --- .github/workflows/go.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 1aa23881..3c5e3137 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - go: [ '1.18', '1.19', '1.20', '1.21', '1.22' ] + go: [ '1.18', '1.19', '1.20', '1.21' ] steps: - name: Set up Go @@ -39,7 +39,7 @@ jobs: - name: Set up Go uses: actions/setup-go@v4 with: - go-version: '1.20' + go-version: '1.21' id: go - name: Git checkout From ef90447db22c5806495a5e41655fc1c36a4bccb1 Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Wed, 14 Feb 2024 19:26:28 -0800 Subject: [PATCH 3/3] ok, lint 1.20 it is --- .github/workflows/go.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 3c5e3137..5fccda16 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -39,7 +39,7 @@ jobs: - name: Set up Go uses: actions/setup-go@v4 with: - go-version: '1.21' + go-version: '1.20' id: go - name: Git checkout