Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize error return from HTTP requests in genqlient #352

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Standardize error return from HTTP requests in genqlient #352

wants to merge 3 commits into from

Conversation

wwzeng1
Copy link

@wwzeng1 wwzeng1 commented Sep 20, 2024 •
edited
Loading

Purpose

This pull request aims to standardize the error handling for HTTP requests in the genqlient library. The current implementation returns a generic error message that makes it difficult to handle specific error scenarios, such as retrying on rate limit errors.

Fixes #333

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@jagregory
Copy link

This would be great to get merged. It's quite painful to handle HTTP errors at the moment. Do you need any help @wwzeng1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjkraft benjaminjkraft Awaiting requested review from benjaminjkraft benjaminjkraft will be requested when the pull request is marked ready for review benjaminjkraft is a code owner

@csilvers csilvers Awaiting requested review from csilvers csilvers will be requested when the pull request is marked ready for review csilvers is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy will be requested when the pull request is marked ready for review dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman will be requested when the pull request is marked ready for review StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardise the error return from http request
2 participants
@wwzeng1 @jagregory