Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer an explicit trigger for timezone list #91

Open
juzerzarif opened this issue Oct 30, 2021 · 6 comments
Open

Offer an explicit trigger for timezone list #91

juzerzarif opened this issue Oct 30, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@juzerzarif
Copy link

Sometimes the Friend-Time bot will list timezones for a time mentioned in a message even when it's not particularly helpful. For example, say I message a channel

I was planning on leaving in 5 minutes

Friend-Time will trigger on "in 5 minutes" and list all the times in the server list. That can get kinda annoying. It would be nice if the timezone list feature could have an explicit trigger - something similar to the "react with ⏰" behavior that it uses for DMs. That way people in the server can prevent false positives.

If we think this is a worthwhile feature, I'm willing to help with a PR (just need some pointers 😅)

@Davi-the-Mudkip
Copy link
Contributor

Sometimes the Friend-Time bot will list timezones for a time mentioned in a message even when it's not particularly helpful. For example, say I message a channel

I was planning on leaving in 5 minutes

Friend-Time will trigger on "in 5 minutes" and list all the times in the server list. That can get kinda annoying. It would be nice if the timezone list feature could have an explicit trigger - something similar to the "react with ⏰" behavior that it uses for DMs. That way people in the server can prevent false positives.

If we think this is a worthwhile feature, I'm willing to help with a PR (just need some pointers 😅)

How would the explicit trigger work?

@juzerzarif
Copy link
Author

I would expect it to work pretty similar to the trigger for DMs. Friend-Time reacts with say 📃 to a message with a time it recognized. Someone in the channel also reacts to the message with 📃 at which point Friend-Time messages the channel with the list of times. Any subsequent reacts with 📃 don't trigger any more messages from Friend-Time.

What do you think @Davi-the-Mudkip

@Davi-the-Mudkip
Copy link
Contributor

I would expect it to work pretty similar to the trigger for DMs. Friend-Time reacts with say 📃 to a message with a time it recognized. Someone in the channel also reacts to the message with 📃 at which point Friend-Time messages the channel with the list of times. Any subsequent reacts with 📃 don't trigger any more messages from Friend-Time.

What do you think @Davi-the-Mudkip

That's excellent!

@KevinNovak KevinNovak added the enhancement New feature or request label Oct 31, 2021
@KevinNovak
Copy link
Owner

I like this idea, I think we would have to limit the trigger to maybe just admins or a certain role however. I'll consider adding this in a future update!

@juzerzarif
Copy link
Author

I like this idea, I think we would have to limit the trigger to maybe just admins or a certain role however. I'll consider adding this in a future update!

Awesome, thank you! Imo a role would be the most convenient. So if you're in a server with all people you know, you can just give everyone that role. Let me know if I can help at all 🙂

@AhmadMajid
Copy link

Sorry I opened a new issue but realised the point has also been made here.

"It makes sense to make conversions when an explicit time is mentioned, for example: 8pm.

But it doesn't make sense to trigger a conversion when somebody says: in 15 minutes.

Every time a user says "in X time-unit" friend bot converting the time in chat is messy. Can something be done about this?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants