Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect daylight savings time #42

Open
atalkingfish opened this issue Jun 1, 2020 · 3 comments
Open

Auto-detect daylight savings time #42

atalkingfish opened this issue Jun 1, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@atalkingfish
Copy link

Typing in “1pm PT” results in “1pm PT: 5 pm ET, etc” which is wrong (it should be 4 pm ET, etc)

Typing in “1pm MT” results in only “1pm” being read, and the time zones are set against the user’s time zone.

@KevinNovak
Copy link
Owner

KevinNovak commented Jun 1, 2020

@atalkingfish I'm still in the process of looking into this but I'm guessing this has to do with daylight savings time. When you type "ET" it is assuming "EST", but because it is currently daylight savings time in the US it should assume "EDT" instead.

As a workaround you can use "EDT"/"MDT" during daylight sayings time and "EST"/"MST" if it's not daylight savings.

@atalkingfish
Copy link
Author

I am aware that using S and D to solve the issue but getting a server full of people to use the right one at the right times of the year is impossible.

@KevinNovak KevinNovak changed the title Typing in “PT” gives the time 1 hour later than the correct one; MT doesn’t work. Auto-detect daylight savings time if time zone abbreviations are mentioned Dec 19, 2020
@KevinNovak
Copy link
Owner

You have a good point, this can definitely be confusing. I'd ideally like to have the bot auto-detect if the time zone is currently in daylight savings, in this scenario where it's not explicitly mentioned.

@KevinNovak KevinNovak added the enhancement New feature or request label Dec 19, 2020
@KevinNovak KevinNovak pinned this issue Dec 21, 2020
@KevinNovak KevinNovak changed the title Auto-detect daylight savings time if time zone abbreviations are mentioned Auto-detect daylight savings time Dec 21, 2020
@KevinNovak KevinNovak unpinned this issue Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants