-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks with Chrome 67 #50
Comments
While I'm not the maintainer or the author of Mostly-Harmless, I think it's safe to assume that this has been abandoned. |
Abandoned is a bit harsh, I'm just very busy with paid work right now. I do intend to get this working again, but a PR fixing the issue would mean I'd get the new version published even faster. |
PR there, it works but there are a few javascript errors with RedditAPI. If anyone can test it in their chrome, that would be awesome. |
Update: I updated the manifest, and it now loads so you can see the icon with past reddit submissions. You can see the number of comments but you can't vote, submit, or other interactive things. This is because of cross-origin-request controls. It looks like it will need to be completely rewritten to get that functionality (more work than I'm going to spend on it). For example reddit-companion is an updated chrome extension for reddit that faced similar issues. Their solutions was to take all requests from popup.html and pass them to background.js (where cors isn't a problem) via chrome message passing. Maybe someone with better knowledge of cors and chrome extensions can see a workaround. An alternative would be to slim it down for now. Removing interactivity in the popup and just taking the user to reddit for voting and submissions. Another would be to load an iframe to the "other discussions" link on reddit. |
In the meantime, if people want a partially functional version, just
Then you will get the mostly harmless icon and link to reddit discussions, but the vote buttons wont work. |
For people who are suffering from the lack of mostly-harmless here's an extension to use in the mean time. It has much of the same functionality: https://chrome.google.com/webstore/detail/reddit-check/mllceaiaedaingchlgolnfiibippgkmj |
The extension vanished with the latest chrome update, trying to reinstall gives me this:
Also, if you upload the crx to https://www.extensiontest.com/ it reports use of a deprecated api in chrome. Maybe that's what breaks it?
The text was updated successfully, but these errors were encountered: