Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with Chrome 67 #50

Open
Jogai opened this issue May 31, 2018 · 6 comments
Open

Breaks with Chrome 67 #50

Jogai opened this issue May 31, 2018 · 6 comments

Comments

@Jogai
Copy link

Jogai commented May 31, 2018

The extension vanished with the latest chrome update, trying to reinstall gives me this:

There was a problem with the download. Please contact the developer or try again later.
Hide details
Invalid manifest

Also, if you upload the crx to https://www.extensiontest.com/ it reports use of a deprecated api in chrome. Maybe that's what breaks it?

@speckz
Copy link

speckz commented May 31, 2018

While I'm not the maintainer or the author of Mostly-Harmless, I think it's safe to assume that this has been abandoned.

@Kerrick
Copy link
Owner

Kerrick commented May 31, 2018

Abandoned is a bit harsh, I'm just very busy with paid work right now. I do intend to get this working again, but a PR fixing the issue would mean I'd get the new version published even faster.

@wassname
Copy link

wassname commented Aug 2, 2018

PR there, it works but there are a few javascript errors with RedditAPI. If anyone can test it in their chrome, that would be awesome.

@wassname
Copy link

wassname commented Aug 4, 2018

Update: I updated the manifest, and it now loads so you can see the icon with past reddit submissions. You can see the number of comments but you can't vote, submit, or other interactive things. This is because of cross-origin-request controls.

It looks like it will need to be completely rewritten to get that functionality (more work than I'm going to spend on it). For example reddit-companion is an updated chrome extension for reddit that faced similar issues. Their solutions was to take all requests from popup.html and pass them to background.js (where cors isn't a problem) via chrome message passing. Maybe someone with better knowledge of cors and chrome extensions can see a workaround.

An alternative would be to slim it down for now. Removing interactivity in the popup and just taking the user to reddit for voting and submissions.

Another would be to load an iframe to the "other discussions" link on reddit.

@wassname
Copy link

wassname commented Aug 9, 2018

In the meantime, if people want a partially functional version, just

  1. download the zip from this PR
  2. unzip
  3. go to chrome extensions
  4. enable developer mode
  5. load unpacked extension.

Then you will get the mostly harmless icon and link to reddit discussions, but the vote buttons wont work.

@wassname
Copy link

wassname commented Sep 8, 2018

For people who are suffering from the lack of mostly-harmless here's an extension to use in the mean time. It has much of the same functionality: https://chrome.google.com/webstore/detail/reddit-check/mllceaiaedaingchlgolnfiibippgkmj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants