Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 응답DTO를 여러개 구현할 예정으로 변경되어 생성응답DTO라고 구체화하는 이름인 NoticeCreateResponseDto로 수정
- 공지사항 수정 요청 및 응답 DTO 구현
- 공지사항 수정 DTO 수정 - 공지사항 수정 서비스 구현 - 공지사항 수정 컨트롤러 구현
- 공지사항 삭제 서비스 구현 - 공지사항 삭제 컨트롤러 구현
quickestfunctioning
requested review from
a121255,
heegu123,
oowtl,
KJU3 and
jaseongkim
as code owners
heegu123
approved these changes
Jan 24, 2025
jaseongkim
reviewed
Jan 24, 2025
module-service/src/main/java/com/checkping/service/notice/NoticeServiceImpl.java
Show resolved
Hide resolved
jaseongkim
approved these changes
Jan 24, 2025
module-service/src/main/java/com/checkping/dto/notice/response/NoticeUpdateResponseDto.java
Show resolved
Hide resolved
oowtl
reviewed
Jan 29, 2025
module-api/src/main/java/com/checkping/api/controller/notice/NoticeController.java
Show resolved
Hide resolved
|
|
||
| private String priority; | ||
|
|
||
| public Notice toEntity(){ |
There was a problem hiding this comment.
이 메서드는 어디에서 사용될까요? 서비스 코드에서는 notice id 로 find 를 해서 나온 결과인 notice 엔티티를 사용하는 것 같아서요
There was a problem hiding this comment.
제거하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
공지사항 삭제 기능
#️⃣ 이슈번호
#246
📋 작업 내용
공지사항 삭제 기능