Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Particle Effect on Enemy Destruction #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LRFLEW
Copy link
Contributor

@LRFLEW LRFLEW commented Oct 3, 2023

I had left a comment on reddit suggesting adding a particle effect when an enemy is destroyed to give the demo a little more impact. This is my (fairly rushed) attempt at implementing something for that. This PR adds an explosion.tscn with a simple particle effect I made and a timer to remove the particle spawner once it's no longer needed. I also updated the enemy script to add the explosion to the scene at the enemy's position when it's destroyed.

The particle effect I made for this is really simplistic, and I'm not sure it's at the same quality as the starter kit as a whole, so I would understand not merging this as-is. I wanted to make the PR for it, though, to have a place for discussion as well as see if there's any ideas to improve it. Right now the particles themselves are very simplistic, just being colored cubes. The mesh and material could be swapped out for something better, and the choice of colors could maybe be improved (I'm colorblind, so I wasn't sure about the best choice of colors). Feel free to mess with this in the editor, but do note that because of godotengine/godot#17903 you'll need to make sure you re-enable emitting before saving the scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant