Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error: Invalid serialization data * #61

Open
tomasstrejcek opened this issue Jul 21, 2016 · 2 comments
Open

Fatal error: Invalid serialization data * #61

tomasstrejcek opened this issue Jul 21, 2016 · 2 comments

Comments

@tomasstrejcek
Copy link

in method RedisStorage::getUnserializedValue, it should be possible to handle possible errors without crashing the whole app

return @unserialize($stored[1]); // intentionally @

could be encapsuled in try {} catch (Throwable $t) {} - to catch it and log it at least in php7 (7.1 alpha 3 +)

we are currently dealing with error "Invalid serialization data for DateTime object", and want to discuss possible/best solutions for this, so we cant fork it then, test in production and send pull request

thanks

(only way to reproduce it we have come up with is this:

php

@KacerCZ
Copy link
Contributor

KacerCZ commented Jul 27, 2016

This issue is related to this PHP bug: https://bugs.php.net/bug.php?id=72011
In PHP 7.0.9 this bug should be fixed.

@tomasstrejcek
Copy link
Author

tomasstrejcek commented Jul 31, 2016

You are correct :) Thanks

It solves our problem but not the general idea behind it ..

@fprochazka have a look at this and if this is irrelevant, then close the issue? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants