Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate the client from the extension #36

Open
bazo opened this issue Jun 14, 2014 · 5 comments
Open

separate the client from the extension #36

bazo opened this issue Jun 14, 2014 · 5 comments

Comments

@bazo
Copy link

bazo commented Jun 14, 2014

i really like your client and i'm using it in some of my libraries. but the libraries can be used without nette, but this lib requires some nette parts, which are not really required for the client, thus it forces the users of my lib to download these nette packages.

i think the client can stand on its own and the extension should just require the client

@fprochazka
Copy link
Member

You mean extracting just the RedisClient class (and drivers), without storages, journals and other classes, to separate repo+package?

@bazo
Copy link
Author

bazo commented Jun 15, 2014

yes, exactly

@enumag
Copy link
Member

enumag commented Jun 15, 2014

What about removing the composer requirements of this package instead?

@fprochazka
Copy link
Member

We could degrade the requirements to just nette/utils and maybe not even that... and then put the others to suggest and/or require-dev.

@enumag
Copy link
Member

enumag commented Jun 15, 2014

Exactly. :-) require-dev already has nette/nette in it so suggest it is. The same might be useful for Kdyby/Doctrine by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants