Make these changes upstream

[khfeng]

This should really gets merged in upstream Linux, so everyone can benefit.

I can send patches to upstream if you don't know how to do it.

Thanks.

[KastB]

Hi
I tried to get this patch upstream but failed (https://www.spinics.net/lists/netdev/msg402795.html). I guess that I removed at least one bug compared to the original patchset, but still there are issues on some systems (see the other open issue #3).
They haven't been happy about an additional kernel parameter and enabling the it by default would cause regressions on some systems.
Perhaps they accept it with a whitelist, that enables ASPM on certain systems, which isn't my favorite solution but probably is achievable and better than the current upstream state. The alternative would be to solve the bugs. When you dig into the r8168 code you can see, that Realtek does some additional stuff when ASPM is activated. Maybe/Probably that is the problem with this driver patch, but I have neither time nor the hardware to check that.
So you are welcome to do the changes and send it upstream. I would really appreciate that.

[khfeng]

IIUC, the maintainer means if this patch works on some systems, then we should enable it mandatorily. We should blacklist systems that are not happy with ASPM. Neither extra module knob nor whitelist works for most users.

I'll continue your work and ask users to do some test before upstream.
Thanks!

[khfeng]

Resend it to upstream:
https://lkml.org/lkml/2017/11/15/93