Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline pages issues #34

Open
pedipanol opened this issue Dec 2, 2024 · 2 comments
Open

offline pages issues #34

pedipanol opened this issue Dec 2, 2024 · 2 comments

Comments

@pedipanol
Copy link

I started using the local HTML files after my ISP for some reason recently started blocking github.io pages, but I found 2 usability issues.

  • The first is that I think there should have proper instructions on the documentation with the instructions to use the local HTML files. It just boils down to renaming the extracted folder to "exSTATic", but that one has to read the manifest file to understand that is not user friendly...

  • The second is that when using local files, when you go to the settings or stats page, they still link you to the github.io page instead of the local files, which work fine if you just open the pages manually, but is an additional chore.

I think I'm an edge case in regards to my isp issue, but I also had just given up on immersion because of internet connection issues before (as I didn't know about renaming the folder), so I think being more offline friendly would be helpful to everyone.

@KamWithK
Copy link
Owner

KamWithK commented Dec 3, 2024

That is a bit weird they're blocking GitHub pages! Never heard of it before.

I'm sorry the docs are a bit lacking around this, but the honest truth is that this was something I added to help with development and then after a while never again touched. As you've guessed you seem to be the first person I've heard actually cares for the feature (a few people temporarily used it without internet though I've heard).

I do want this to be improved but I myself can't really remember much/anything about it and have a more pressing feature requests to consider for the limited time I'll set aside for learn Japanese projects.
Nonetheless I don't believe in closing issues as stale or won't do, so I'll leave this open for yourself or anyone else to pick up. It wouldn't be hard to PR with instructions and/or a fix for opening the stats page locally too.

@KamWithK
Copy link
Owner

KamWithK commented Dec 3, 2024

Also the main reason the stats page doesn't auto open locally (I knew it was jank like that already) is I assumed you'd just check your stats the next day when you got internet back hah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants