Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking emoji reactions counts up ad infinitum #18

Open
dnisbetjones opened this issue Apr 13, 2023 · 2 comments
Open

Clicking emoji reactions counts up ad infinitum #18

dnisbetjones opened this issue Apr 13, 2023 · 2 comments

Comments

@dnisbetjones
Copy link

See video:

Screen.Recording.2023-04-12.at.20.51.54.mov
@kenrachynski
Copy link
Contributor

I looked at this in the debugger.
When we draw the message we add in any available reactions as individual buttons. When you click that button, we call removeReaction and then fetchReactions. Unfortunately, we don't remove all the buttons that are already there so we end up incrementing the value instead of, you know, removing the button.

So we'll have to figure out how to smartly refresh reactions on the message when they're refetched and remove buttons if they get to zero. i.e. not in the array we fetch from the homeserver.

@kenrachynski
Copy link
Contributor

kenrachynski commented May 12, 2023

Although, after "removing" my 👍 via Eigen and adding it again via Element... I'm getting this:
image
because it doesn't fall in the myUserHasReacted part of the logic tree. we only increment the number if myUserHasReacted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants