From 05e458f610d7d66866356a29165391276ee22dbb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 1 Nov 2024 08:36:26 -0500 Subject: [PATCH 1/2] chore(deps): bump @pine-ds/icons from 8.6.0 to 8.10.0 (#2019) Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.6.0 to 8.10.0. - [Release notes](https://github.com/Kajabi/pine-icons/releases) - [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md) - [Commits](https://github.com/Kajabi/pine-icons/compare/v8.6.0...v8.10.0) --- updated-dependencies: - dependency-name: "@pine-ds/icons" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index cebeae66a6..3512c0fbd5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2849,9 +2849,9 @@ "@octokit/openapi-types" "^12.11.0" "@pine-ds/icons@^8.0.0": - version "8.6.0" - resolved "https://registry.yarnpkg.com/@pine-ds/icons/-/icons-8.6.0.tgz#22faaa67832d38d4d4ca64cd56bbc497781a11a6" - integrity sha512-UuvQ+kve39Nhewy1+xPkVjnpp84N3B03DIUowDC1vYanVnU92LDryf7fohcOmiwEiONG/jI6KgiiSvRiz5U1SA== + version "8.10.0" + resolved "https://registry.yarnpkg.com/@pine-ds/icons/-/icons-8.10.0.tgz#92b5cd4f159aff42cbf194b8b64dcf06786d5434" + integrity sha512-wli20s0/C00BQdBFkOydwWu3muGcSXSkFy8NGhWHgGheP52aEJzBtfYYH34M495pNLODQ6oif5z/WNt8Ezz/8w== dependencies: "@stencil/core" "^4.20.0" From 4ce4b4d23d7d24dc98bd7eb76c5bde17fc503c64 Mon Sep 17 00:00:00 2001 From: Quinton Jason Date: Wed, 6 Nov 2024 12:06:29 -0600 Subject: [PATCH 2/2] style: resolve logical properties issue with dropdown (#2020) * style: update physical properties to not use logical props * Revert "style: update physical properties to not use logical props" This reverts commit 18d20e06a8a774560364b2c50c231669c42034fa. * style: update incorrect logical properties --- .../lib/stylesheets/components/_button.scss | 14 +++++++------- .../lib/stylesheets/components/_dropdown.scss | 4 ++-- .../lib/stylesheets/components/_tooltip.scss | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/sage-assets/lib/stylesheets/components/_button.scss b/packages/sage-assets/lib/stylesheets/components/_button.scss index 1a7ec3f13a..338d1ac18a 100644 --- a/packages/sage-assets/lib/stylesheets/components/_button.scss +++ b/packages/sage-assets/lib/stylesheets/components/_button.scss @@ -281,7 +281,7 @@ $-btn-loading-min-height: rem(36px); display: flex; justify-content: center; position: absolute; - inset-inline-start: 0; + inset-inline-end: 0; width: $-btn-interactive-badge-icon-size; margin: auto 0; border-radius: 0 sage-border(radius-x-large) sage-border(radius-x-large) 0; @@ -348,7 +348,7 @@ $-btn-loading-min-height: rem(36px); .sage-panel-controls__toolbar-btn-group > &:not(.sage-btn--secondary) { position: absolute; - inset-inline-start: 0; + inset-inline-end: 0; inset-block-end: 0; min-height: calc(#{$-btn-toolbar-group-height} + #{rem(2px)}); /* expand to toolbar group height + border offset */ } @@ -438,18 +438,18 @@ $-btn-loading-min-height: rem(36px); @include sage-icon-base(caret-down, md, pine); position: absolute; - inset-inline-start: 1rem; + inset-inline-end: 1rem; } &[class*="icon-only"]::after { @include sage-icon-base(caret-down, xs, pine); - inset-inline-start: $-btn-disclosure-left-padding; + inset-inline-end: $-btn-disclosure-left-padding; font-weight: sage-font-weight(bold); } &[class*="icon-only"].sage-btn--small::after { - inset-inline-start: rem(12px); + inset-inline-end: rem(12px); } &:has(pds-icon) { @@ -475,7 +475,7 @@ $-btn-loading-min-height: rem(36px); } &::after { - left: 7px; + right: 7px; font-size: 11px; font-weight: sage-font-weight(bold); } @@ -731,7 +731,7 @@ a.sage-btn { // Remove class when Sage Label is fully deprecated in Products .sage-label & { position: absolute; - inset-inline-start: sage-spacing(xs); + inset-inline-end: sage-spacing(xs); } } } diff --git a/packages/sage-assets/lib/stylesheets/components/_dropdown.scss b/packages/sage-assets/lib/stylesheets/components/_dropdown.scss index 70fe9fbe06..a91794d045 100644 --- a/packages/sage-assets/lib/stylesheets/components/_dropdown.scss +++ b/packages/sage-assets/lib/stylesheets/components/_dropdown.scss @@ -317,7 +317,7 @@ $-dropdown-trigger-dropdown-offset: rem(16px) + sage-spacing(xs); } .sage-dropdown--anchor-right > .sage-dropdown__panel & { - inset-inline-start: 0; + inset-inline-end: 0; } .sage-dropdown--small & { @@ -359,7 +359,7 @@ $-dropdown-trigger-dropdown-offset: rem(16px) + sage-spacing(xs); } .sage-dropdown--anchor-right & { - inset-inline-start: 0; + inset-inline-end: 0; } .sage-dropdown--anchor-center & { diff --git a/packages/sage-assets/lib/stylesheets/components/_tooltip.scss b/packages/sage-assets/lib/stylesheets/components/_tooltip.scss index a9bd15196f..a0c57c1761 100644 --- a/packages/sage-assets/lib/stylesheets/components/_tooltip.scss +++ b/packages/sage-assets/lib/stylesheets/components/_tooltip.scss @@ -63,7 +63,7 @@ $-tooltip-large-maxwidth: rem(320px); .sage-tooltip--bottom { &::after { left: 50%; - right: 100%; + bottom: 100%; transform: translate3d(-50%, 0, 0); border-inline-start: $-tooltip-arrow-inactive; border-inline-end: $-tooltip-arrow-inactive; @@ -80,7 +80,7 @@ $-tooltip-large-maxwidth: rem(320px); .sage-tooltip--left { &::after { left: 100%; - right: 50%; + bottom: 50%; transform: translate3d(0, 50%, 0); border-block-start: $-tooltip-arrow-inactive; border-block-end: $-tooltip-arrow-inactive; @@ -102,7 +102,7 @@ $-tooltip-large-maxwidth: rem(320px); .sage-tooltip--right { &::after { left: 0; - right: 50%; + bottom: 50%; transform: translate3d(-100%, 50%, 0); border-block-start: $-tooltip-arrow-inactive; border-block-end: $-tooltip-arrow-inactive;