Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Choice Card: add switch type and conditional block #570

Open
philschanely opened this issue Jun 10, 2021 · 0 comments
Open
Labels
enhancement New feature or request P4 Not critical: workarounds exist and/or not a high priority item.

Comments

@philschanely
Copy link
Contributor

Description

Problem: Right now there is some ambiguity related to when and how to use the Radio bordered versus the Choice card. Related, there is a similar overlap between Switch bordered and feature toggle. Behind the scenes the Choice Card is primarily set up to work like a tab selection, activating a separate tab pane, yet cases exist where a panel within the card itself should toggle instead.

Proposal: This proposal involves several aspects:

  1. Consolidate all "bordered" options out from Radio and Switch onto Choice. Choice would have Switch as a new "icon" option (it already has radio, icon, and arrow). Form fields can still be behind the scenes as is currently set up through the radio_configs prop on Choice (although this prop may need to be renamed as input_configs and allow for type as a new option within it). The end goal here would be that any uses of SageSwitch or SageRadio that use bordered could instead use SageChoice and benefit from a single interface.
  2. Add a new optional affordance on SageChoice for a slot within the card itself to toggle on and off as the choice is selected and deselected. This should allow for any content to be passed within, and is most likely to be used for providing additional form fields for settings related to the option that the user has selected through selecting that choice card.
@philschanely philschanely added the enhancement New feature or request label Jun 10, 2021
@philschanely philschanely added the P4 Not critical: workarounds exist and/or not a high priority item. label Dec 15, 2021
@philschanely philschanely added this to the TEMP: Backlog milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P4 Not critical: workarounds exist and/or not a high priority item.
Projects
None yet
Development

No branches or pull requests

1 participant