Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add a Fieldset element #1007

Open
teenwolfblitzer opened this issue Nov 9, 2021 · 0 comments
Open

[Suggestion] Add a Fieldset element #1007

teenwolfblitzer opened this issue Nov 9, 2021 · 0 comments
Assignees
Labels
a11y Accessibility related P4 Not critical: workarounds exist and/or not a high priority item. suggestion Suggestion to improve the Sage System

Comments

@teenwolfblitzer
Copy link
Member

teenwolfblitzer commented Nov 9, 2021

Description

Groups of related form elements (checkboxes and radio buttons in particular) stand to benefit from the addition of a Sage fieldset (and legend).

  • Using a fieldset will clearly define the relationship between controls to screen readers
  • Developers will gain the ability to enable and disable entire sets of controls at once
  • Testing can be simplified by allowing grouped form controls to be scoped under a single test_id

Discussion points/considerations

  • Styling fieldset styling: remove border and padding as defaults?
  • Intended for functional use only, not as a styled "container"
  • legend should be required but provide an option to visually hide

Additional Information

@teenwolfblitzer teenwolfblitzer added a11y Accessibility related suggestion Suggestion to improve the Sage System labels Nov 9, 2021
@teenwolfblitzer teenwolfblitzer self-assigned this Nov 19, 2021
@philschanely philschanely added the P4 Not critical: workarounds exist and/or not a high priority item. label Dec 14, 2021
@philschanely philschanely added this to the TEMP: Backlog milestone Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility related P4 Not critical: workarounds exist and/or not a high priority item. suggestion Suggestion to improve the Sage System
Projects
None yet
Development

No branches or pull requests

2 participants