Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dictionary: Refactor to ASCII List with keys Table in element 0 #233

Closed
CookingWithCale opened this issue May 1, 2022 · 0 comments
Closed

Dictionary: Refactor to ASCII List with keys Table in element 0 #233

CookingWithCale opened this issue May 1, 2022 · 0 comments
Assignees
@CookingWithCale
Labels
help wanted Extra attention is needed
Milestone
Remapped ASCII Da...

Comments

@CookingWithCale
Copy link
Collaborator

CookingWithCale commented May 1, 2022 •
edited
Loading

Problem

The problem the current memory layout is not the same as the new Book memory layout that uses a List with Loom keys in element 0.

Solution

The solution is to do the repeat the Book changes for the Dic and get that unit test to pass.

Files Affected

  1. Dic.hpp

Hierarchy

Tags

Mission

Sessions

License

Copyright ©2022 Kabuki Starship; all rights reserved.
@CookingWithCale CookingWithCale changed the title Spec.Data.MapTypes.Dictionary.Update memory layout to use a List with Table keys as element 0. Spec.Data.MapTypes.Dictionary.Update memory layout to use a List with Table keys as element 0 May 4, 2022
@CookingWithCale CookingWithCale self-assigned this May 4, 2022
@CookingWithCale CookingWithCale added help wanted Extra attention is needed good first issue Good for newcomers and removed good first issue Good for newcomers labels May 27, 2022
@CookingWithCale CookingWithCale changed the title Spec.Data.MapTypes.Dictionary.Update memory layout to use a List with Table keys as element 0 Dictionary.Update memory layout to use a List with Table keys as element 0; update spec May 27, 2022
@CookingWithCale CookingWithCale changed the title Dictionary.Update memory layout to use a List with Table keys as element 0; update spec Dictionary.Remap memory layout to use a List with Table keys hashmap as element 0; update spec Sep 4, 2024
@CookingWithCale CookingWithCale changed the title Dictionary.Remap memory layout to use a List with Table keys hashmap as element 0; update spec Dictionary: Remap memory layout to use a List with Table keys hashmap as element 0 Oct 26, 2024
@CookingWithCale CookingWithCale changed the title Dictionary: Remap memory layout to use a List with Table keys hashmap as element 0 Dictionary: Refactor to ASCII List with keys Table in element 0 Oct 26, 2024
CookingWithCale added a commit that referenced this issue Oct 30, 2024
@CookingWithCale
Dictionary: Refactor to ASCII List with keys Table in element 0 #233.…
c2dda30 
…E Code is working and tested by is not printing the values.
CookingWithCale added a commit that referenced this issue Oct 30, 2024
@CookingWithCale
Merge pull request #304 from KabukiStarship/Issue233
61f04ca 
 Dictionary: Refactor to ASCII List with keys Table in element 0 #233…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CookingWithCale CookingWithCale

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
Remapped ASCII Data Types
Development

No branches or pull requests
1 participant
@CookingWithCale