Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutrient concentration change in implementation #80

Open
val-ismaili opened this issue Mar 10, 2025 · 0 comments · May be fixed by #81
Open

Nutrient concentration change in implementation #80

val-ismaili opened this issue Mar 10, 2025 · 0 comments · May be fixed by #81
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@val-ismaili
Copy link
Collaborator

Currently, nutrient concentration statistics are inputted as values in g/L. One of the key purposes of pysimdeum discharge simulation is to be able to simulate and measure change in nutrient concentration based on enduse behaviour changes.

Example:
Conceptually, it makes sense that a user will use the same amount of soap when washing their hands at a BathroomTap regardless of the amount of water consumed, and then discharged. By providing nutrient stats in units g/L, this implies that the total nutrients deposited in the discharge flow will vary at every use i.e. the actual concentration will stay constant. However, we would want to provide total volume of nutrients per use i.e. g/use. This would then be used to calculate the g/L concentration for that specific consumption - discharge event.

The current architecture of the nutrient concentration object is still applicable. However, there is a need to alter the calculation by:

  1. Input stats g/L --> g/use
  2. Identify unique discharge events
  3. Distribute nutrients across that usage event --> thereby calculating concentration in g/L
@val-ismaili val-ismaili added bug Something isn't working enhancement New feature or request labels Mar 10, 2025
@val-ismaili val-ismaili self-assigned this Mar 10, 2025
@val-ismaili val-ismaili linked a pull request Mar 12, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant