Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the Assembly Utils. #66

Open
2 tasks
Lisias opened this issue Nov 30, 2023 · 2 comments
Open
2 tasks

Revise the Assembly Utils. #66

Lisias opened this issue Nov 30, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Lisias
Copy link
Collaborator

Lisias commented Nov 30, 2023

On TweakScale/TweakScale#312 (comment) , one KSP idiosyncrasy was finally diagnosed:

there is one difference between System.AppDomain.CurrentDomain.GetAssemblies() and the AssemblyLoader's list - and it comes into play when a hard-referenced dependency wasn't found (i.e. the cases where you remove 999_scale_redist). In that case, the Scale.dll assembly will NOT be in the AssemblyLoader's list but it WILL be in the System.AppDomain.CurrentDomain.GetAssemblies() list. I think this explains some of the differences you see, depending on other mods that might be using one of these or the other.

Tasks:

  • Check the everything (properly) loaded on System.AppDomain.CurrentDomain.GetAssemblies() also appears on AssemblyLoader's list
  • If positive, use the later on KSPe's routines instead of the former.
@Lisias Lisias self-assigned this Nov 30, 2023
@Lisias Lisias added the enhancement New feature or request label Nov 30, 2023
@Lisias Lisias added this to the 2.5.4.0 milestone Mar 24, 2024
@Lisias
Copy link
Collaborator Author

Lisias commented Mar 29, 2024

This thing may also be related (or affected) by #56.

@Lisias
Copy link
Collaborator Author

Lisias commented Dec 11, 2024

On a second thought... If we have assemblies failed to be loaded on the rig, do we really want to keep the game running? This is a fucking disaster waiting to happen, because installed assemblies are expected to provide features that would not be provided - leading to really weird and unexpected borkages.

This, indeed, may be the reason some people are complaining about really weird problems happening on KSP lately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant