Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit hook should ignore unstaged files #34

Open
ghost opened this issue Oct 15, 2015 · 0 comments
Open

Commit hook should ignore unstaged files #34

ghost opened this issue Oct 15, 2015 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 15, 2015

The formatting commit hook will also try to modify files which have been changed but are not meant to be committed (yet). This will fail the commit, as the hook requires all changes in files it modifies to be staged/commited/stashed.

This seems unreasonable to me - a file that is not meant to be committed does not need to be formatted implicitly and should also not fail the commit. I suggest that the (formatting) commit hook is set to implicitly check only files which are to be committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants