New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for `extern "C++Qt"` with type, fn, and signals #577

Closed

4 tasks done

ahayzen-kdab opened this issue Jun 7, 2023 · 2 comments · Fixed by #1084

Closed

4 tasks done

Add support for `extern "C++Qt"` with type, fn, and signals #577

ahayzen-kdab opened this issue Jun 7, 2023 · 2 comments · Fixed by #1084

Assignees

Labels

⬆️ feature 👷 refactor 🥳🎉 1.0

Collaborator

ahayzen-kdab commented Jun 7, 2023 •

edited by LeonMatthesKDAB

Loading

Our current generation is mostly about the extern "RustQt" side, once #557 is done we'll have extern "RustQt" with support for inherit and signals. Then #558 adds support for invokables and #559 for type and properties.

But we also want to support foreign types (eg type QButton), so we need to support extern "C++Qt".

Add support in parser phase for C++Qt
Add support in generation phases for a type that is foreign (it only needs to generate CXX bridges and the signal connect parts?)
Ensure that type QButton;, fn show(self: Pin<&mut QButton>);, #[qsignal] fn clicked(self: Pin<&mut QButton>) work, but note that qproperty, inherit, qinvokable should not work ?
Change connections to be DirectConnection by default and make choosing a connection type as an unsafe closure (as QueuedConnection could have a mutable reference to something and be executed at any time in the future)

Consider any notes from #527

The text was updated successfully, but these errors were encountered:

ahayzen-kdab added 🥳🎉 1.0 ⬆️ feature 👷 refactor labels

ahayzen-kdab changed the title ~~Add support for extern "C++Qt with type, fn, and signals~~ Add support for extern "C++Qt" with type, fn, and signals

ahayzen-kdab mentioned this issue

Add extern "Qt" - allow signals on existing Qt classes #527

Closed

ahayzen-kdab self-assigned this

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: parse all items and use Path::get_ident instead of helper

16e0c8d

This then allows us to easily parse extern "C++Qt" later.

Related to KDAB#577

ahayzen-kdab mentioned this issue

cxx-qt-gen: parse all items and use Path::get_ident instead of helper #626

Merged

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: parse all items and use Path::get_ident instead of helper

b035fd9

This then allows us to easily parse extern "C++Qt" later.

Related to KDAB#577

Be-ing pushed a commit that referenced this issue


          cxx-qt-gen: parse all items and use Path::get_ident instead of helper

0d74bbd

This then allows us to easily parse extern "C++Qt" later.

Related to #577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: store module ident in parser and simplify populating mapping

6bbef8d

This also simplifies extern "C++Qt" support later.

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: build qualified mappings for QObject inline

f29e627

Rather than building the qualified mappings of the qobject
after already parsing them, do this inline. And build a
helper method to build a Path from two idents without parsing.

Related to KDAB#577

ahayzen-kdab mentioned this issue

cxx-qt-gen: store module ident in parser and simplify populating mapping #628

Merged

Be-ing pushed a commit that referenced this issue


          cxx-qt-gen: store module ident in parser and simplify populating mapping

9cbc1ea

This also simplifies extern "C++Qt" support later.

Related to #577

Be-ing pushed a commit that referenced this issue


          cxx-qt-gen: build qualified mappings for QObject inline

d22007d

Rather than building the qualified mappings of the qobject
after already parsing them, do this inline. And build a
helper method to build a Path from two idents without parsing.

Related to #577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: split populating mappings from extern blocks into helper

This allows us to reuse it for extern "C++Qt" blocks later.

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add parsing phase of extern "C++Qt"

Related to KDAB#577

ahayzen-kdab mentioned this issue

cxx-qt-gen: add parsing phase of extern "C++Qt" #631

Merged

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: split populating mappings from extern blocks into helper

39c16b5

This allows us to reuse it for extern "C++Qt" blocks later.

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add parsing phase of extern "C++Qt"

002d16a

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: split populating mappings from extern blocks into helper

2573f6f

This allows us to reuse it for extern "C++Qt" blocks later.

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add parsing phase of extern "C++Qt"

a05160a

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: split locking generation and add unsafeRustLock method

362386a

This simplifies the C++ source files as they can use the helper method.

This allows later for a templated signal connect that can use the
public helper method to lock the QObject.

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: split populating mappings from extern blocks into helper

8c54667

This allows us to reuse it for extern "C++Qt" blocks later.

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add parsing phase of extern "C++Qt"

ad71add

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: split locking generation and add unsafeRustLock method

294c028

This simplifies the C++ source files as they can use the helper method.

This allows later for a templated signal connect that can use the
public helper method to lock the QObject.

Related to KDAB#577

Be-ing pushed a commit that referenced this issue


          cxx-qt-gen: split locking generation and add unsafeRustLock method

365906c

This simplifies the C++ source files as they can use the helper method.

This allows later for a templated signal connect that can use the
public helper method to lock the QObject.

Related to #577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: split populating mappings from extern blocks into helper

bd37156

This allows us to reuse it for extern "C++Qt" blocks later.

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add parsing phase of extern "C++Qt"

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add parsing phase of extern "C++Qt"

89066f3

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: share QSignal free namespace generation in naming module

34fa65f

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add Rust generator and writer of extern "C++Qt"

8831f83

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: share QSignal free namespace generation in naming module

f5a81de

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add Rust generator and writer of extern "C++Qt"

4f6f339

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: share QSignal free namespace generation in naming module

48e7b61

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add Rust generator and writer of extern "C++Qt"

5bf64c6

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: share QSignal free namespace generation in naming module

2b6a244

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          WIP: examples: add example of using a signal on an external object

96ccb34

Related to KDAB#577

ahayzen-kdab mentioned this issue

examples: add example of using a signal on an external object #670

Merged

Be-ing pushed a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: add Rust generator and writer of extern "C++Qt"

6d3f0cc

Related to KDAB#577

Be-ing pushed a commit to ahayzen-kdab/cxx-qt that referenced this issue


          cxx-qt-gen: share QSignal free namespace generation in naming module

cf5ad21

Related to KDAB#577

ahayzen-kdab added a commit that referenced this issue


          cxx-qt-gen: add Rust generator and writer of extern "C++Qt"

f0bd09d

Related to #577

ahayzen-kdab added a commit that referenced this issue


          cxx-qt-gen: share QSignal free namespace generation in naming module

91230cc

Related to #577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          WIP: examples: add example of using a signal on an external object

94505fc

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          WIP: examples: add example of using a signal on an external object

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

d184a57

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

5ac870e

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

12817aa

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

e9baac4

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

7134b61

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

49d870e

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

593ca9e

Related to KDAB#577

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue


          examples: add example of using a signal on an external object

95e5ad5

Related to KDAB#577

ahayzen-kdab added a commit that referenced this issue


          examples: add example of using a signal on an external object

a0b1772

Related to #577

Collaborator

LeonMatthesKDAB commented Jan 17, 2024

TODO: Check correct marker Traits (Send, Sync, etc.)

LeonMatthesKDAB added a commit to LeonMatthesKDAB/cxx-qt that referenced this issue


          Fix: Require Send on closures connected to signals

3a2dcda

The closures may be executed on a different thread, depending on where
the emitting object lives.

Also closes KDAB#577. We have determined that is indeed safe to queue a
deferred closure, as the closure will not be called if the object is
deleted, as we use the object itself as the context.

LeonMatthesKDAB mentioned this issue

Fix: Require Send on closures connected to signals #1084

Merged

ahayzen-kdab pushed a commit to LeonMatthesKDAB/cxx-qt that referenced this issue


          Fix: Require Send on closures connected to signals

9d0d9a7

The closures may be executed on a different thread, depending on where
the emitting object lives.

Also closes KDAB#577. We have determined that is indeed safe to queue a
deferred closure, as the closure will not be called if the object is
deleted, as we use the object itself as the context.

ahayzen-kdab closed this as completed in #1084

ahayzen-kdab pushed a commit that referenced this issue


          Fix: Require Send on closures connected to signals

dff128f

The closures may be executed on a different thread, depending on where
the emitting object lives.

Also closes #577. We have determined that is indeed safe to queue a
deferred closure, as the closure will not be called if the object is
deleted, as we use the object itself as the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment