From 72dc734cf95c4e982af88aca77ba3d2765abf2d1 Mon Sep 17 00:00:00 2001 From: Leon Matthes Date: Wed, 12 Jun 2024 11:24:20 +0200 Subject: [PATCH] ci: Use windows-2019 instead of -latest We've been dealing with an issue in CI, where the test-signal test case fails when building in Release mode on Windows. It fails in the ConnectionEvaluator, when it tries to lock the mutex, which is something that should simply not happen, as the shared_ptr in the testcase keeps the ConnectionEvaluator alive at the point where the crash occurs. In addition, this problem is not reproducable anywhere outside Githubs CI. If I copy the executable from Github Actions to my local machine, it simply works. This leads me to believe this is only a problem with this very specific Windows environment. By downgrading our Windows version in CI, we can avoid the problem and at least continue development. --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e89d4c5..1e52bd6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,7 +20,7 @@ jobs: matrix: os: - ubuntu-latest - - windows-latest + - windows-2019 - macos-latest steps: