Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current method for "between" fill works okay but need to support curve cross fill patterns. #77

Open
JustinGOSSES opened this issue Mar 21, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@JustinGOSSES
Copy link
Owner

In the current behavior, the color is filled in between the two curves no matter which curve (1 or 2) is left or right of the over.

That's okay for most things, but there will probably be a wanted behavior where curve 1 left of curve 2 will produce one color fill and curve 1 right of curve 2 will produce another color fill.

Additionally, there might be a fill wanted where one fill is only present if curve 1 crosses curve 2 to the high side and another fill only present if curve 2 cross curve 1 to the low side.

There might be additionally combinations of this. Unsure whether these should be built in as sub-types of "between" fill or separate fill types?

Additional context
ALSO, I am unsure how high a priority this is.

@JustinGOSSES JustinGOSSES self-assigned this Mar 21, 2020
@JustinGOSSES JustinGOSSES added enhancement New feature or request question Further information is requested labels Mar 21, 2020
@aberridg
Copy link

In my opinion this is a high priority enhancement. It's the first thing that was mentioned to me when I demonstrated the plot to potential users. I have been working on this experimentally - need to do more.

@JustinGOSSES
Copy link
Owner Author

@aberridg can you list out some of the fill behaviors you would like to see?

@aberridg
Copy link

aberridg commented Feb 3, 2021

The only one I know about so far is for the fill colour to change when two curves cross over. Particularly when looking at the crossover between RHOB and NPHI (Density and Neutron Porosity). The fill colour change indicates where oil may be found. The crossover should be calculated on the x (measure axis) positions, so that different scales can be used to represent the different magnitudes of the units used for the different measures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Long Term & Evaluation : To do
Development

No branches or pull requests

2 participants