Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit depths (max and min) so it works on multiple levels #50

Open
JustinGOSSES opened this issue Feb 6, 2020 · 0 comments
Open
Assignees
Labels
bug Something isn't working core feature a core feature

Comments

@JustinGOSSES
Copy link
Owner

Describe the bug

max_depth and min_depth doesn't quite work as it should

Expected behavior
A clear and concise description of what you expected to happen.

A max_depth key:value refers to the depth that is used as the plotting max depth no matter the actual deepest depth found in a curve/well.

For example, if there was a well where the curves all went to 200 but the max depth was set to be 180, the curves would only be plotted to 180.

Another example, if there was a well where all the curves had a deepest point of 120 but the max depth was 180, then the plot would show empty space below where the curve lines were all the way down to 200.

This is not the same as "top_depth" or "bottom_depth" used to describe how to create a depth curve along with the interval. For example, top = 100, bottom = 200, and interval = 5.

There should be a way to set max_depth and min_depth at different levels of organization that then flow to smaller levels.

For example, you should be able to set max_depth and min_depth at the curve, curve_box, and cross_section level.
Also, any max_depth set at cross_section should be applied to the curve_box and each curve.

This means the code should:

  • Check for max_depth and min_depth when building cross-sections and if it appears as anything except "not_applicable", or some other decided phrase, then that max_depth or min_depth should be applied to each max_depth of the curve_boxes contained within.
  • When in the curveBox function, the code should defer to the max_depth and min_depth for explicit top and bottom for scaling if they exist. It should also loop through the data array of objects and throw out any objects in the array that are outside the max_depth and min_depth.
@JustinGOSSES JustinGOSSES added bug Something isn't working core feature a core feature labels Feb 6, 2020
@JustinGOSSES JustinGOSSES self-assigned this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core feature a core feature
Projects
Status: Core Features TO DO
Development

No branches or pull requests

1 participant