Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShutdownOnFarmingFinished weekly #3364

Open
8 tasks done
Nuklon opened this issue Dec 21, 2024 · 4 comments
Open
8 tasks done

ShutdownOnFarmingFinished weekly #3364

Nuklon opened this issue Dec 21, 2024 · 4 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered.

Comments

@Nuklon
Copy link

Nuklon commented Dec 21, 2024

Checklist

Enhancement purpose

To be eligible for booster packs, you need to sign in at least once a week:

Booster packs are granted randomly to eligible users as more badges are crafted by members of the community. Make sure you log in to Steam each week to maintain eligibility.

I propose an alternative in FarmingPreferences where the bot shuts down, but reconnects to Steam at least once a week. Say WeeklyShutdownOnFarmingFinished

Solution

See "Enhancement purpose".

Why currently available solutions are not sufficient?

See "Enhancement purpose".

Can you help us with this enhancement idea?

Somehow, I can test and offer feedback, but can't code

Additional info

No response

@Nuklon Nuklon added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Dec 21, 2024
@nolddor
Copy link
Contributor

nolddor commented Dec 21, 2024

Note that you can configure a crontab or Task Scheduler to start and/or restart ASF at desired cadence. i.e. Once a week on Sundays.

@JustArchi
Copy link
Member

This is overly complicated for achieving that, what is stopping you from having bot enabled that simply doesn't do anything, but stays logged in? I'm very skeptical to this idea since it requires a lot of code to do right, can introduce crazy amount of bugs and suddenly people will expect that ASF actually can log in weekly without any issues, which is a cost I don't want to endure, since it should be a job for dedicated ASF plugin rather than core.

@Nuklon
Copy link
Author

Nuklon commented Dec 22, 2024

I don't need to have all my alt accounts connected constantly, but I would like for them to be eligible for boosters.

and suddenly people will expect that ASF actually can log in weekly without any issues

I don't follow what you mean here. An alternative option would be to add a Restart option perhaps? Say you specify Restart: "24:00:00", to restart the bot every 24 hours since ASF has started.

@Abrynos
Copy link
Member

Abrynos commented Dec 22, 2024

You can do all that without increasing maintenance burden on ASF team. ASF has IPC-API for this. I'd recommend configuring your bots as disabled and havin a cronjob start them once a week and a second one firing half an hour later stopping the bots again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered.
Projects
None yet
Development

No branches or pull requests

4 participants