Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing persistent key-value database for third-parties #2337

Closed
JustArchi opened this issue Jun 17, 2021 · 3 comments
Closed
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@JustArchi
Copy link
Member

Something similar to my work project, where we'll allow authenticated users to store arbitrary values under unique keys.

Api should be like GET "some-unique-key" and POST "some-unique-key" "some-value".

This will allow other services, such as ASF-ui, to permanently store its own stuff in ASF's database, potentially being able to implement stuff like JustArchiNET/ASF-ui#1428 without being on ASF's mercy on doing it properly.

The database will be shared, every consumer will be expected to prepend its unique keys with some project identifier, this way we won't have conflicts over used properties.

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. labels Jun 17, 2021
@JustArchi
Copy link
Member Author

/cc @MrBurrBurr

@JustArchi
Copy link
Member Author

JustArchi commented Jun 17, 2021

Note: this is expected to be API only, plugins should implement their own configs and databases similar to STD if they expect to have a similar functionality. I do not plan on making those endpoints available to them, as the values can't make use of the glorious solutions that C# gives us, such as strong-typing the saved structure.

But this is still up to final decision, I didn't make up my mind about it yet.

@JustArchi
Copy link
Member Author

^ The plugins can use the above as well, if for some reason they don't want to implement their own, strong-typed classes using already-existing SerializableFile ASF abstraction.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

No branches or pull requests

1 participant