Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASF-ui should cache GitHub releases #1624

Open
5 tasks done
JustArchi opened this issue Jan 7, 2023 · 1 comment
Open
5 tasks done

ASF-ui should cache GitHub releases #1624

JustArchi opened this issue Jan 7, 2023 · 1 comment
Assignees
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.

Comments

@JustArchi
Copy link
Member

Checklist

  • I read and understood ASF-ui's Contributing Guidelines
  • I also read FAQ
  • My idea doesn't duplicate existing ASF-ui functionality described on the wiki
  • I believe that my idea falls into ASF-ui's scope and should be offered as part of ASF-ui built-in functionality
  • This is not ASF suggestion

Enhancement purpose

As a third-party service, GitHub has various rate-limits in regards to fetching its resources. We should use cache for all third-party resources that ASF can't fulfill on its own. The caching doesn't have to be excessive, could be even 5 minutes, but lack of any caching can lead to users rate-limiting themselves accidentally purely by navigating across ASF-ui from one tab to another.

Solution

All /api/www/github endpoints should be carefully evaluated and cached. I'm pretty sure the functionality that checks for ASF updates already uses the cache, same mechanism should be used for Releases tab, which from my fast network tab check, always fetches info on each refresh.

Why currently available solutions are not sufficient?

obraz

Can you help us with this enhancement idea?

Somehow, I can test and offer feedback, but can't code

Additional info

/cc @MrBurrBurr

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jan 7, 2023
@JustArchi JustArchi changed the title ASF-ui should change GitHub releases ASF-ui should cache GitHub releases Jan 7, 2023
@JustArchi
Copy link
Member Author

JustArchi commented Jan 7, 2023

Alternative that I thought of would be implementing that caching inside ASF core, but then I take away the freedom from you to invalidate it and force ASF to do the check, and adding additional booleans such as force: true sound nasty and require ASF-ui edits anyway. I believe it'd be best if ASF-ui handled it itself as a direct caller.

@MrBurrBurr MrBurrBurr added 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Dec 16, 2023
@MrBurrBurr MrBurrBurr self-assigned this Dec 16, 2023
@MrBurrBurr MrBurrBurr added the 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants