Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@__MODULE__ is not defined on 0.6 #16

Open
bjarthur opened this issue May 9, 2018 · 3 comments
Open

@__MODULE__ is not defined on 0.6 #16

bjarthur opened this issue May 9, 2018 · 3 comments

Comments

@bjarthur
Copy link

bjarthur commented May 9, 2018

b0e887c introduces a breaking change:

https://github.com/JunoLab/Media.jl/blob/master/src/system.jl#L73

@bjarthur
Copy link
Author

bjarthur commented May 9, 2018

@compat fixes this, but Media.jl does not currently REQUIRE Compat. do you plan to drop support for 0.6 or utilize compat?

@bjarthur
Copy link
Author

bjarthur commented May 9, 2018

actually, it's still broken with @compat:

julia> using Gadfly

julia> plot(y=[1])
Error showing value of type Gadfly.Plot:
ERROR: StackOverflowError:
Stacktrace:
 [1] media(::Type{T} where T) at /Users/arthurb/.julia/v0.6/Media/src/system.jl:70 (repeats 80000 times)

reverting back to current_module() fixes it. a bug in compat?

@pfitzseb
Copy link
Member

pfitzseb commented May 14, 2018

I don't think we'll keep master compatible with Julia 0.6 since Juno development will switch to 0.7 in the near future and I'm not aware of any bugs that would necessitate a new Media.jl release for 0.6.

Should definitely update Media's REQUIRE file though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants