Skip to content

Accept URI in download function #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mfsch
Copy link

@mfsch mfsch commented May 8, 2025

The request-based functions (e.g. HTTP.get) accept the URI type for the url argument, but the download function currently only accepts strings. This (tiny) change allows URIs there too.

@fredrikekre
Copy link
Member

Looks good, can you add a test?

@mfsch
Copy link
Author

mfsch commented May 12, 2025

I’ve added a test – however, it looks like the tests for download were commented out in #1065. Maybe @quinnj remembers why? Commenting them in an running Pkg.test("HTTP", test_args = ["download.jl"]) runs without error for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants