Skip to content

Preserve aspect ratio and make size changeable #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2024
Merged

Preserve aspect ratio and make size changeable #30

merged 1 commit into from
Mar 17, 2024

Conversation

ut112002
Copy link
Member

@VarLad VarLad mentioned this pull request Mar 17, 2024
Merged
@arhik
Copy link
Member

arhik commented Mar 17, 2024

tested the example included and on cube and splat.jl examples. works on my side. Thanks.

arhik
arhik reviewed Mar 17, 2024
View reviewed changes
Copy link
Member

@arhik arhik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ignore main function comment. I will have to redesign a little more abstractions for that happen.

@arhik
Copy link
Member

arhik commented Mar 17, 2024

I will merge this after wrapping error as commented here JuliaWGPU/WGPUCanvas.jl#5 (comment). Let me know its conflicting with anything.

@arhik arhik merged commit 7f35261 into JuliaWGPU:main Mar 17, 2024
3 checks passed
@arhik
Copy link
Member

arhik commented Mar 17, 2024

Thank you @ut112002 and @VarLad. I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhik arhik arhik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ut112002 @arhik